linux-kernel - Re: [PATCH] iommu/qcom: Simplify a test in 'qcom_iommu_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190917062312.GF18977@kadam>
Date:   Tue, 17 Sep 2019 09:23:12 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     agross@...nel.org, robdclark@...il.com, joro@...tes.org,
        linux-arm-msm@...r.kernel.org, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iommu/qcom: Simplify a test in 'qcom_iommu_add_device()'

On Mon, Sep 16, 2019 at 10:29:36PM +0200, Christophe JAILLET wrote:
> 'iommu_group_get_for_dev()' never returns NULL, so this test can be
> simplified a bit.
> 

It used to until commit 72dcac633475 ("iommu: Warn once when device_group
callback returns NULL").

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter