linux-kernel - Re: [PATCH] sched: Add __ASSEMBLY__ guards around struct clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190917074909.GA49590@gmail.com>
Date:   Tue, 17 Sep 2019 09:49:09 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Seth Forshee <seth.forshee@...onical.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Christian Brauner <christian@...uner.io>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Add __ASSEMBLY__ guards around struct clone_args


* Seth Forshee <seth.forshee@...onical.com> wrote:

> The addition of struct clone_args to uapi/linux/sched.h is not
> protected by __ASSEMBLY__ guards, causing a FTBFS for glibc on
> RISC-V. Add the guards to fix this.
> 
> Fixes: 7f192e3cd316 ("fork: add clone3")
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>
> ---
>  include/uapi/linux/sched.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/sched.h b/include/uapi/linux/sched.h
> index b3105ac1381a..851ff1feadd5 100644
> --- a/include/uapi/linux/sched.h
> +++ b/include/uapi/linux/sched.h
> @@ -33,6 +33,7 @@
>  #define CLONE_NEWNET		0x40000000	/* New network namespace */
>  #define CLONE_IO		0x80000000	/* Clone io context */
>  
> +#ifndef __ASSEMBLY__
>  /*
>   * Arguments for the clone3 syscall
>   */
> @@ -46,6 +47,7 @@ struct clone_args {
>  	__aligned_u64 stack_size;
>  	__aligned_u64 tls;
>  };
> +#endif

Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo