linux-kernel - Re: linux-next: Tree for Sep 16 (kernel/sched/core.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190917075242.GB49590@gmail.com>
Date:   Tue, 17 Sep 2019 09:52:42 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: linux-next: Tree for Sep 16 (kernel/sched/core.c)


* Randy Dunlap <rdunlap@...radead.org> wrote:

> On 9/16/19 3:38 PM, Mark Brown wrote:
> > Hi all,
> > 
> > Changes since 20190915:
> > 
> 
> on x86_64:
> 
> when CONFIG_CGROUPS is not set:
> 
>   CC      kernel/sched/core.o
> ../kernel/sched/core.c: In function ‘uclamp_update_active_tasks’:
> ../kernel/sched/core.c:1081:23: error: storage size of ‘it’ isn’t known
>   struct css_task_iter it;
>                        ^~
>   CC      kernel/printk/printk_safe.o
> ../kernel/sched/core.c:1084:2: error: implicit declaration of function ‘css_task_iter_start’; did you mean ‘__sg_page_iter_start’? [-Werror=implicit-function-declaration]
>   css_task_iter_start(css, 0, &it);
>   ^~~~~~~~~~~~~~~~~~~
>   __sg_page_iter_start
> ../kernel/sched/core.c:1085:14: error: implicit declaration of function ‘css_task_iter_next’; did you mean ‘__sg_page_iter_next’? [-Werror=implicit-function-declaration]
>   while ((p = css_task_iter_next(&it))) {
>               ^~~~~~~~~~~~~~~~~~
>               __sg_page_iter_next
> ../kernel/sched/core.c:1091:2: error: implicit declaration of function ‘css_task_iter_end’; did you mean ‘get_task_cred’? [-Werror=implicit-function-declaration]
>   css_task_iter_end(&it);
>   ^~~~~~~~~~~~~~~~~
>   get_task_cred
> ../kernel/sched/core.c:1081:23: warning: unused variable ‘it’ [-Wunused-variable]
>   struct css_task_iter it;
>                        ^~
> 

I cannot reproduce this build failue: I took Linus's latest which has all 
the -next scheduler commits included (ad062195731b), and an x86-64 "make 
defconfig" and a disabling of CONFIG_CGROUPS still resuls in a kernel 
that builds fine.

Thanks,

	Ingo