linux-kernel - [PATCH 1/4] mfd: rk808: fix rk818 ID template

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190917081256.24919-1-heiko@sntech.de>
Date:   Tue, 17 Sep 2019 10:12:53 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     lee.jones@...aro.org
Cc:     linux-kernel@...r.kernel.org, d.schultz@...tec.de,
        linux-rockchip@...ts.infradead.org,
        christoph.muellner@...obroma-systems.com, tony.xie@...k-chips.com,
        stable@...r.kernel.org, Elaine Zhang <zhangqing@...k-chips.com>,
        Joseph Chen <chenjh@...k-chips.com>,
        Heiko Stuebner <heiko@...ech.de>
Subject: [PATCH 1/4] mfd: rk808: fix rk818 ID template

From: Daniel Schultz <d.schultz@...tec.de>

The Rockchip PMIC driver can automatically detect connected component
versions by reading the ID_MSB and ID_LSB registers. The probe function
will always fail with RK818 PMICs because the ID_MSK is 0xFFF0 and the
RK818 template ID is 0x8181.

This patch changes this value to 0x8180.

Fixes: 9d6105e19f61 ("mfd: rk808: Fix up the chip id get failed")
Cc: stable@...r.kernel.org
Cc: Elaine Zhang <zhangqing@...k-chips.com>
Cc: Joseph Chen <chenjh@...k-chips.com>
Signed-off-by: Daniel Schultz <d.schultz@...tec.de>
Acked-by: Lee Jones <lee.jones@...aro.org>
[resend as it seems to have dropped on the floor]
Signed-off-by: Heiko Stuebner <heiko@...ech.de>
---
 include/linux/mfd/rk808.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/rk808.h b/include/linux/mfd/rk808.h
index 7cfd2b0504df..a59bf323f713 100644
--- a/include/linux/mfd/rk808.h
+++ b/include/linux/mfd/rk808.h
@@ -610,7 +610,7 @@ enum {
 	RK808_ID = 0x0000,
 	RK809_ID = 0x8090,
 	RK817_ID = 0x8170,
-	RK818_ID = 0x8181,
+	RK818_ID = 0x8180,
 };
 
 struct rk808 {
-- 
2.20.1