linux-kernel - Re: [PATCH] nvmem: core: fix nvmem_cell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5e97c02-2fa5-17bc-bed3-851d7b58b1f5@linaro.org>
Date:   Tue, 17 Sep 2019 09:20:52 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>, Sebastian Reichel <sre@...nel.org>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.com>,
        kbuild test robot <lkp@...el.com>,
        Han Nandor <nandor.han@...sala.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmem: core: fix nvmem_cell_write inline function



On 17/09/2019 08:57, Arnd Bergmann wrote:
> On Mon, Sep 9, 2019 at 3:45 PM Sebastian Reichel <sre@...nel.org> wrote:
>>
>> From: Sebastian Reichel <sebastian.reichel@...labora.com>
>>
>> nvmem_cell_write's buf argument uses different types based on
>> the configuration of CONFIG_NVMEM. The function prototype for
>> enabled NVMEM uses 'void *' type, but the static dummy function
>> for disabled NVMEM uses 'const char *' instead. Fix the different
>> behaviour by always expecting a 'void *' typed buf argument.
>>
>> Fixes: 7a78a7f7695b ("power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface")
>> Reported-by: kbuild test robot <lkp@...el.com>
>> Cc: Han Nandor <nandor.han@...sala.com>
>> Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> Cc: linux-kernel@...r.kernel.org
>> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> I still see the issue in linux-next, did this get dropped by accident?
> 

I just pushed it to nvmem tree, should be fixed in next soon!

--srini
>        Arnd
>