[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMz4kuJczzjTPSohQ=kbZ0Pr7U_9-hzXk-jPgKk79PENOM1-dA@mail.gmail.com>
Date: Tue, 17 Sep 2019 17:23:13 +0800
From: Baolin Wang <baolin.wang@...aro.org>
To: Aurabindo Jayamohanan <mail@...abindo.in>
Cc: Mark Brown <broonie@...nel.org>, palmer@...ive.com,
paul.walmsley@...ive.com, linux-spi <linux-spi@...r.kernel.org>,
linux-riscv@...ts.infradead.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: sifive: check return value for platform_get_resource()
On Tue, 17 Sep 2019 at 17:12, Aurabindo Jayamohanan <mail@...abindo.in> wrote:
>
> platform_get_resource() may return NULL. If it is so, return -ENXIO
>
> Signed-off-by: Aurabindo Jayamohanan <mail@...abindo.in>
> ---
> drivers/spi/spi-sifive.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c
> index 93ec2c6cdbfd..67485067a694 100644
> --- a/drivers/spi/spi-sifive.c
> +++ b/drivers/spi/spi-sifive.c
> @@ -308,6 +308,12 @@ static int sifive_spi_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, master);
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(&pdev->dev, "no IOMEM resource found\n");
> + ret = -ENXIO;
> + goto put_master;
> + }
Seems unnecessary, the devm_ioremap_resource() already validated if
the resource is available.
--
Baolin Wang
Best Regards
Powered by blists - more mailing lists