linux-kernel - Re: [PATCH v5] tas2770: add tas2770 smart PA kernel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190917104955.GB3524@sirena.co.uk>
Date:   Tue, 17 Sep 2019 11:49:55 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "shifu0704@...ndersoft.com" <shifu0704@...ndersoft.com>
Cc:     lgirdwood <lgirdwood@...il.com>, perex <perex@...ex.cz>,
        tiwai <tiwai@...e.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        alsa-devel <alsa-devel@...a-project.org>,
        robh+dt <robh+dt@...nel.org>, Dan?Murphy <dmurphy@...com>,
        "Navada Kanyana, Mukund" <navada@...com>
Subject: Re: [PATCH v5] tas2770: add tas2770 smart PA kernel driver

On Tue, Sep 17, 2019 at 03:40:59PM +0800, shifu0704@...ndersoft.com wrote:

> > +reload:
> > + /* hardware reset and reload */
> > + tas2770_load_config(tas2770);

> Sometimes devices need to be reset to return to normal, and this setting is necessary.

But why do we have systems where the device is being reset?  Like I keep
saying I'd just get a normal driver merged first, then go back and
figure out what's going on with the reset support so it can be reviewed
separately.

> > +end:
> > + return IRQ_HANDLED;
> > +}

> I see that the other drivers, the return values in irq_handler are IRQ_HANDLED.

If they've actually handled an interrupt.  There's some buggy drivers
that do it unconditionally, they aren't a good reason to add more.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)