linux-kernel - Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190917105519.GB18936@lem-wkst-02.lemonage>
Date:   Tue, 17 Sep 2019 12:55:19 +0200
From:   Lars Poeschel <poeschel@...onage.de>
To:     David Miller <davem@...emloft.net>
Cc:     allison@...utok.net, keescook@...omium.org, opensource@...ayne.com,
        swinslow@...il.com, gregkh@...uxfoundation.org,
        gustavo@...eddedor.com, tglx@...utronix.de,
        kstewart@...uxfoundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, johan@...nel.org
Subject: Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability

On Wed, Sep 11, 2019 at 10:17:59AM +0200, David Miller wrote:
> From: Lars Poeschel <poeschel@...onage.de>
> Date: Tue, 10 Sep 2019 11:34:12 +0200
> 
> > +static int pn533_autopoll_complete(struct pn533 *dev, void *arg,
> > +			       struct sk_buff *resp)
> > +{
> > +	u8 nbtg;
> > +	int rc;
> > +	struct pn532_autopoll_resp *apr;
> > +	struct nfc_target nfc_tgt;
> 
> Need reverse christmas tree here.

See below.

> > @@ -1534,6 +1655,7 @@ static int pn533_start_poll(struct nfc_dev *nfc_dev,
> >  	struct pn533_poll_modulations *cur_mod;
> >  	u8 rand_mod;
> >  	int rc;
> > +	struct sk_buff *skb;
> 
> Likewise.

I will do a v8 with these changes soon.