linux-kernel - Re: [PATCH 2/3] i2c: qup: Remove dev_err() log after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190917162508.GB5388@SD>
Date:   Tue, 17 Sep 2019 21:55:08 +0530
From:   Saiyam Doshi <saiyamdoshi.in@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/3] i2c: qup: Remove dev_err() log after
 platform_get_irq*() failure

On Tue, Sep 17, 2019 at 05:28:47PM +0200, Markus Elfring wrote:
> > The semantic patch that makes this report is available
> > in scripts/coccinelle/api/platform_get_irq.cocci.
> >
> > Found using - http://coccinelle.lip6.fr/
> 
> Can a tag like “Generated by: scripts/coccinelle/api/platform_get_irq.cocci”
> be more helpful than the other description variant?
Okay, will update the changelog.

> >  	if (qup->irq < 0) {
> > -		dev_err(qup->dev, "No IRQ defined\n");
> >  		return qup->irq;
> >  	}
> How do you think about to omit the curly brackets here after only a single
> statement would be used in the if branch?
Completely missed that! I will update and resend.

-Saiyam