[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190917163628.GA2615@Mani-XPS-13-9360>
Date: Tue, 17 Sep 2019 22:06:28 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Stephen Boyd <sboyd@...nel.org>
Cc: afaerber@...e.de, robh+dt@...nel.org, ulf.hansson@...aro.org,
linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
thomas.liau@...ions-semi.com, linux-actions@...ts.infradead.org,
linus.walleij@...aro.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 1/7] clk: actions: Fix factor clk struct member access
On Tue, Sep 17, 2019 at 09:34:18AM -0700, Stephen Boyd wrote:
> Quoting Manivannan Sadhasivam (2019-09-16 08:45:40)
> > Since the helper "owl_factor_helper_round_rate" is shared between factor
> > and composite clocks, using the factor clk specific helper function
> > like "hw_to_owl_factor" to access its members will create issues when
> > called from composite clk specific code. Hence, pass the "factor_hw"
> > struct pointer directly instead of fetching it using factor clk specific
> > helpers.
> >
> > This issue has been observed when a composite clock like "sd0_clk" tried
> > to call "owl_factor_helper_round_rate" resulting in pointer dereferencing
> > error.
> >
> > While we are at it, let's rename the "clk_val_best" function to
> > "owl_clk_val_best" since this is an owl SoCs specific helper.
> >
> > Fixes: 4bb78fc9744a ("clk: actions: Add factor clock support")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > Reviewed-by: Stephen Boyd <sboyd@...nel.org>
> > ---
>
> I can apply this to clk-next?
Yes, please :-) Rest can go through Ulf's tree.
Thanks,
Mani
>
Powered by blists - more mailing lists