linux-kernel - Re: [PATCH v2] selftests: watchdog: Validate optional file argument

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190917165418.GA21010@vmlxhi-102.adit-jv.com>
Date:   Tue, 17 Sep 2019 18:54:18 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     shuah <shuah@...nel.org>
CC:     Eugeniu Rosca <erosca@...adit-jv.com>,
        "George G. Davis" <george_davis@...tor.com>,
        Eugeniu Rosca <roscaeugeniu@...il.com>,
        Jerry Hoemann <jerry.hoemann@....com>,
        Colin Ian King <colin.king@...onical.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] selftests: watchdog: Validate optional file argument

Shuah,

On Tue, Sep 17, 2019 at 09:25:31AM -0600, shuah wrote:

[..]

> I want two patches and the first one with
> Fixes tag. 

I am not sure we are on the same page and you don't seem to be receptive
to what I say.

> The reason for that is that the first patch fixes a problem
> in patch that is already in my tree which is fixes a problem.

Here is my understanding of your request:

 +--------------+    +--------------+
 |1/2 this patch|    |1/2 this patch|
 |    (fix)     +----+  (feature)   |
 +------+-------+    +--------------+
        | Fixes
 +------v-------+
 |     [A]      |
 +------+-------+
        | Fixes
 +------v-------+
 |     [B]      |
 +--------------+

So, you ask to decompose this v2 patch into two parts (fix and feature),
__exactly like it was in v1__, with the reasoning that the bugfix
related part of this patch fixes [A] (which is true), while [A] fixes
another commit [B]. But given that [A] is a feature commit, adding brand
new functionality, there can't be any [B] commit being fixed by [A].

> I am going to mark the patch for stables and the first patch in this
> series.

I do not understand your request. Both current patch and [A] are
scheduled for v5.4. I do not see any relevant patches for linux-stable.
I hope either a clarification or a third opinion will shed more light
onto this totally unproductive dialogue.

[A] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=c3f2490d6e92
    ("selftests: watchdog: Add optional file argument")
    https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=c3f2490d6e92
    ("selftests: watchdog: Add optional file argument")
[B] ???

-- 
Best Regards,
Eugeniu.