linux-kernel - Re: [PATCH v5 4/5] doc: media: vimc: Update module parameter usage information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da086043-6e01-983a-dc0c-9656f01494e6@collabora.com>
Date:   Tue, 17 Sep 2019 16:27:07 -0300
From:   Helen Koike <helen.koike@...labora.com>
To:     Shuah Khan <skhan@...uxfoundation.org>, mchehab@...nel.org,
        andrealmeid@...labora.com, dafna.hirschfeld@...labora.com,
        hverkuil-cisco@...all.nl
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 4/5] doc: media: vimc: Update module parameter usage
 information



On 9/17/19 1:35 PM, Shuah Khan wrote:
> vimc driver is now a monolithic driver. Update the module parameter
> usage information to reflect that.
> 
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>

Acked-by: Helen Koike <helen.koike@...labora.com>

> ---
>  Documentation/media/v4l-drivers/vimc.rst | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/media/v4l-drivers/vimc.rst b/Documentation/media/v4l-drivers/vimc.rst
> index 406417680db5..a582af0509ee 100644
> --- a/Documentation/media/v4l-drivers/vimc.rst
> +++ b/Documentation/media/v4l-drivers/vimc.rst
> @@ -76,22 +76,22 @@ vimc-capture:
>  	* 1 Pad sink
>  	* 1 Pad source
>  
> -Module options
> +
> +        Module options
>  ---------------
>  
> -Vimc has a few module parameters to configure the driver. You should pass
> -those arguments to each subdevice, not to the vimc module. For example::
> +Vimc has a few module parameters to configure the driver.
>  
> -        vimc_subdevice.param=value
> +        param=value
>  
> -* ``vimc_scaler.sca_mult=<unsigned int>``
> +* ``sca_mult=<unsigned int>``
>  
>          Image size multiplier factor to be used to multiply both width and
>          height, so the image size will be ``sca_mult^2`` bigger than the
>          original one. Currently, only supports scaling up (the default value
>          is 3).
>  
> -* ``vimc_debayer.deb_mean_win_size=<unsigned int>``
> +* ``deb_mean_win_size=<unsigned int>``
>  
>          Window size to calculate the mean. Note: the window size needs to be an
>          odd number, as the main pixel stays in the center of the window,
>