linux-kernel - Re: [PATCH 2/2] block, bfq: delete "bfq" prefix from cgroup filenames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB57492FC0194EFB7506147533868F0@BYAPR04MB5749.namprd04.prod.outlook.com>
Date:   Tue, 17 Sep 2019 21:04:52 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Paolo Valente <paolo.valente@...aro.org>,
        Jens Axboe <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "bfq-iosched@...glegroups.com" <bfq-iosched@...glegroups.com>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
        Tejun Heo <tj@...nel.org>,
        "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        Angelo Ruocco <angeloruocco90@...il.com>
Subject: Re: [PATCH 2/2] block, bfq: delete "bfq" prefix from cgroup filenames

Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>
On 09/17/2019 09:52 AM, Paolo Valente wrote:
> From: Angelo Ruocco<angeloruocco90@...il.com>
>
> When bfq was merged into mainline, there were two I/O schedulers that
> implemented the proportional-share policy: bfq for blk-mq and cfq for
> legacy blk. bfq's interface files in the blkio/io controller have the
> same names as cfq. But the cgroups interface doesn't allow two
> entities to use the same name for their files, so for bfq we had to
> prepend the "bfq" prefix to each of its files. However no legacy code
> uses these modified file names. This naming also causes confusion, as,
> e.g., in [1].
>
> Now cfq has gone with legacy blk, so there is no need any longer for
> these prefixes in (the never used) bfq names. In view of this fact, this
> commit removes these prefixes, thereby enabling legacy code to truly
> use the proportional share policy in blk-mq.
>
> [1]https://github.com/systemd/systemd/issues/7057
>
> Signed-off-by: Angelo Ruocco<angeloruocco90@...il.com>
> Signed-off-by: Paolo Valente<paolo.valente@...aro.org>