linux-kernel - Re: [v2,1/1] hwmon: (nct7904) Fix the incorrect value of vsen_mask in nct7904

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190917222942.GA1994@roeck-us.net>
Date:   Tue, 17 Sep 2019 15:29:42 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Amy.Shih@...antech.com.tw
Cc:     she90122@...il.com, oakley.ding@...antech.com.tw,
        bichan.lu@...antech.com.tw, Jean Delvare <jdelvare@...e.com>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [v2,1/1] hwmon: (nct7904) Fix the incorrect value of vsen_mask
 in nct7904_data struct.

On Mon, Sep 16, 2019 at 11:41:11AM +0800, Amy.Shih@...antech.com.tw wrote:
> From: "amy.shih" <amy.shih@...antech.com.tw>
> 
> Voltage sensors overlap with external temperature sensors. Detect
> the multi-function of voltage, thermal diode and thermistor from
> register VT_ADC_MD_REG to set value of vsen_mask in nct7904_data
> struct.
> 
> Signed-off-by: amy.shih <amy.shih@...antech.com.tw>
> ---
> Changes in v2:
> - Moved the if statement to outside.
>  drivers/hwmon/nct7904.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 95b447cfa24c..e2b3ec74491a 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -921,6 +921,8 @@ static int nct7904_probe(struct i2c_client *client,
>  			data->tcpu_mask &= ~bit;
>  		else if (val == 0x1 || val == 0x2)
>  			data->temp_mode |= bit;
> +		if (val != 0)
> +			data->vsen_mask &= ~(0x06 << (i * 2));

This is a slight change in semantics, since val != 0 includes 3.
Should this maybe be as foillows ?

               if (val == 0) {
                        data->tcpu_mask &= ~bit;
                else {
			if (val == 0x1 || val == 0x2)
                        	data->temp_mode |= bit;
			data->vsen_mask &= ~(0x06 << (i * 2));
		}


Also, please you have a look at the code further above.

		val = (ret & (0x03 << i)) >> (i * 2);

Should that possibly be as follows ?

		val = (ret & (0x03 << i * 2)) >> (i * 2);
		                      ^^^^^

or, somewhat simplified,

		val = (ret >> i * 2) & 0x03;

Thanks,
Guenter