linux-kernel - Re: [GIT PULL] LED updates for 5.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9924d94a-d3f2-b47e-4676-70b3f1771703@gmail.com>
Date:   Wed, 18 Sep 2019 21:00:33 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        ada@...rsis.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Dan Murphy <dmurphy@...com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "Enrico Weigelt, metux IT consult" <info@...ux.net>,
        Joe Perches <joe@...ches.com>, kw@...ux.com,
        Linus Walleij <linus.walleij@...aro.org>,
        nishkadg.linux@...il.com, nstoughton@...itech.com, oleg@....org.ua,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Tony Lindgren <tony@...mide.com>, wenwen@...uga.edu,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [GIT PULL] LED updates for 5.4-rc1

On 9/18/19 9:23 AM, Andy Shevchenko wrote:
> On Wed, Sep 18, 2019 at 10:16 AM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> On Tue, Sep 17, 2019 at 6:13 PM Linus Torvalds
>> <torvalds@...ux-foundation.org> wrote:
>>>
>>> So this is fine and I've pulled it,
>>
>> Famous last words. I now get a new warning:
>>
>> drivers/i2c/i2c-core-acpi.c:347:12: warning:
>> ‘i2c_acpi_find_match_adapter’ defined but not used [-Wunused-function]
>>   347 | static int i2c_acpi_find_match_adapter(struct device *dev,
>> const void *data)
>>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> with this pull request.  I'll have to look at it after dinner.
>>
>>               Linus
> 
> One of those *device core* patch broke i2c ACPI, which has been fixed by
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/i2c/i2c-core-acpi.c?id=644bf60088955421051e716ab9c8fe7fb7997fd7
> 
> As I read above the merge commit didn't take this patch.

It's my bad that I didn't notice the warning, but after the problem
was caught and fixed it would have been good to notify all parties that
may have pulled broken commit.

> Solution might be to merge this PR after corresponding bundle of
> device core stuff.
> 

-- 
Best regards,
Jacek Anaszewski