linux-kernel - Re: [PATCH] block: Fix implicit unsigned to signed conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR04MB5749E2705682FDAFEC213887868E0@BYAPR04MB5749.namprd04.prod.outlook.com>
Date:   Wed, 18 Sep 2019 19:38:29 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Alessio Balsini <balsini@...roid.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-team@...roid.com" <kernel-team@...roid.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] block: Fix implicit unsigned to signed conversion

Since this is a conceptual error and will not cause any bug
not sure if this needed as things are not leading to any bugs.

However cleanup is helpful in avoiding any confusion.

Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 09/18/2019 03:39 AM, Alessio Balsini wrote:
> An unsigned integer variable may be assigned negative values, and is
> returned by the function with an implicit conversion to signed.  Besides
> the implicit conversion at return time for which the variable
> representation is fine and there is no variable manipulation that may
> lead to bugs in the current code base, this is a conceptual error.
>
> Fix by changing the variable type from unsigned to signed.
>
> Signed-off-by: Alessio Balsini<balsini@...roid.com>
> Cc: Jens Axboe<axboe@...nel.dk>