linux-kernel - Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Sep 2019 15:45:32 -0400
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     Christian.Koenig@....com, emamd001@....edu, smccaman@....edu,
        kjlu@....edu, Alex Deucher <alexander.deucher@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Rex Zhu <Rex.Zhu@....com>,
        Sam Ravnborg <sam@...nborg.org>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks

On Wed, Sep 18, 2019 at 3:09 PM Navid Emamdoost
<navid.emamdoost@...il.com> wrote:
>
>         i2s_pdata = kcalloc(3, sizeof(struct i2s_platform_data), GFP_KERNEL);
>         if (i2s_pdata == NULL) {
> -               kfree(adev->acp.acp_res);
> -               kfree(adev->acp.acp_cell);
> -               return -ENOMEM;
> +               ret = -ENOMEM;
> +               goto out3;
>         }

I don't see a corresponding kfree() for i2s_pdata in acp_hw_fini().
Could this be a memory leak?