linux-kernel - [PATCH] platform/x86: asus-wmi: add ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Sep 2019 21:56:33 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Kristian Klausen <kristian@...usen.dk>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] platform/x86: asus-wmi: add ACPI_BATTERY dependency

Without this dependency, we can run into a link failure:

drivers/platform/x86/asus-wmi.o: In function `asus_wmi_remove':
asus-wmi.c:(.text+0x430): undefined reference to `battery_hook_unregister'
drivers/platform/x86/asus-wmi.o: In function `asus_wmi_probe':
asus-wmi.c:(.text+0x2c6f): undefined reference to `battery_hook_register'

Fixes: 7973353e92ee ("platform/x86: asus-wmi: Refactor charge threshold to use the battery hooking API")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 1b67bb578f9f..d81de3f4f72e 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -680,6 +680,7 @@ config ASUS_WMI
 	depends on RFKILL || RFKILL = n
 	depends on HOTPLUG_PCI
 	depends on ACPI_VIDEO || ACPI_VIDEO = n
+	depends on ACPI_BATTERY
 	select INPUT_SPARSEKMAP
 	select LEDS_CLASS
 	select NEW_LEDS
-- 
2.20.0