linux-kernel - Re: [HELP REQUESTED from the community] Was: Staging status of speakup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190918203032.GA3987@gregn.net>
Date:   Wed, 18 Sep 2019 13:30:33 -0700
From:   Gregory Nowak <greg@...gn.net>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     devel@...verdev.osuosl.org,
        Simon Dickson <simonhdickson@...il.com>,
        "Speakup is a screen review system for Linux." 
        <speakup@...ux-speakup.org>, linux-kernel@...r.kernel.org,
        John Covici <covici@....covici.com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        okash.khawaja@...il.com, Didier Spaier <didier@...nt.fr>
Subject: Re: [HELP REQUESTED from the community] Was: Staging status of
 speakup

On Wed, Sep 18, 2019 at 08:16:42AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 17, 2019 at 06:03:53PM -0700, Gregory Nowak wrote:
> > On Tue, Sep 17, 2019 at 10:01:18AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Sep 16, 2019 at 03:38:48PM -0700, Gregory Nowak wrote:
> > > > On Mon, Sep 16, 2019 at 04:11:00PM +0200, Greg Kroah-Hartman wrote:
> > > > > On Mon, Sep 16, 2019 at 03:47:28PM +0200, Samuel Thibault wrote:
> > > > > > Okash Khawaja, le dim. 15 sept. 2019 19:41:30 +0100, a ecrit:
> > > > > > > I have attached the descriptions.
> > > > > > 
> > > > > > Attachment is missing :)
> > > > > 
> > > > > I saw it :)
> > > > > 
> > > > > Anyway, please put the Description: lines without a blank after that,
> > > > > with the description text starting on that same line.
> > > > > 
> > > > > thanks!
> > > > > 
> > > > > greg k-h
> > > > 
> > > > It's attached. Hope the indentation is OK.
> > > 
> > > Alignment is a bit off, you forgot a tab after "Description:"
> > > 
> > > And you have some trailing whitespace in the document :(
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > I put in the tabs after "Description:" and did the best I could to fix
> > the alignment, and to find and get rid of the white space. If the
> > alignment is still off, or if there is still white space I missed,
> > could someone else please correct that? Thanks.
> 
> Extra line between each attribute (before the "What:" line) would be
> nice.

In a previous post above, you wrote:
On Mon, Sep 16, 2019 at 04:11:00PM +0200, Greg Kroah-Hartman wrote:
> Anyway, please put the Description: lines without a blank after that,
> with the description text starting on that same line.

I understood that to mean that the description text should start on
the same line, and the blank lines after the description text should
be removed. I've put them back in. Someone more familiar with the
speakup code will have to dig into it to resolve the TODO items I
suppose.

On Wed, Sep 18, 2019 at 03:28:05PM +0200, Didier Spaier wrote:
> Trailing white spaces removed in attachment.
> Alignment LGTM.

Thank you. This is the copy I put the blank lines into, and am
attaching with the original file name.

Greg N


-- 
web site: http://www.gregn.net
gpg public key: http://www.gregn.net/pubkey.asc
skype: gregn1
(authorization required, add me to your contacts list first)
If we haven't been in touch before, e-mail me before adding me to your contacts.

--
Free domains: http://www.eu.org/ or mail dns-manager@...org

View attachment "sysfs-driver-speakup" of type "text/plain" (14321 bytes)