| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <48eccb97-5dee-f1cd-5650-59a0bafd3044@redhat.com>
Date: Wed, 18 Sep 2019 13:54:46 +0800
From: Jason Wang <jasowang@...hat.com>
To: Cornelia Huck <cohuck@...hat.com>
Cc: kvm@...r.kernel.org, linux-s390@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
intel-gfx@...ts.freedesktop.org,
intel-gvt-dev@...ts.freedesktop.org, kwankhede@...dia.com,
alex.williamson@...hat.com, mst@...hat.com,
zhenyuw@...ux.intel.com, zhi.a.wang@...el.com,
jani.nikula@...ux.intel.com, joonas.lahtinen@...ux.intel.com,
rodrigo.vivi@...el.com, airlied@...ux.ie, daniel@...ll.ch,
farman@...ux.ibm.com, pasic@...ux.ibm.com, sebott@...ux.ibm.com,
oberpar@...ux.ibm.com, heiko.carstens@...ibm.com,
gor@...ux.ibm.com, borntraeger@...ibm.com, akrowiak@...ux.ibm.com,
pmorel@...ux.ibm.com, freude@...ux.ibm.com, tiwei.bie@...el.com,
virtualization@...ts.linux-foundation.org,
maxime.coquelin@...hat.com, cunming.liang@...el.com,
zhihong.wang@...el.com, rob.miller@...adcom.com, idos@...lanox.com,
xiao.w.wang@...el.com, lingshan.zhu@...el.com
Subject: Re: [RFC PATCH 2/2] mdev: introduce device specific ops
On 2019/9/17 下午8:42, Cornelia Huck wrote:
> On Thu, 12 Sep 2019 17:40:12 +0800
> Jason Wang <jasowang@...hat.com> wrote:
>
>> Currently, except for the crate and remove. The rest fields of
>> mdev_parent_ops is just designed for vfio-mdev driver and may not help
>> for kernel mdev driver. So follow the device id support by previous
>> patch, this patch introduces device specific ops which points to
>> device specific ops (e.g vfio ops). This allows the future drivers
>> like virtio-mdev to implement its own device specific ops.
>>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
>> ---
>> drivers/gpu/drm/i915/gvt/kvmgt.c | 14 +++---
>> drivers/s390/cio/vfio_ccw_ops.c | 14 +++---
>> drivers/s390/crypto/vfio_ap_ops.c | 10 +++--
>> drivers/vfio/mdev/vfio_mdev.c | 30 +++++++------
>> include/linux/mdev.h | 72 ++++++++++++++++++-------------
>> samples/vfio-mdev/mbochs.c | 16 ++++---
>> samples/vfio-mdev/mdpy.c | 16 ++++---
>> samples/vfio-mdev/mtty.c | 14 +++---
>> 8 files changed, 113 insertions(+), 73 deletions(-)
>> diff --git a/include/linux/mdev.h b/include/linux/mdev.h
>> index f85045392120..3b8a76bc69cf 100644
>> --- a/include/linux/mdev.h
>> +++ b/include/linux/mdev.h
>> @@ -27,27 +27,9 @@ int mdev_set_iommu_device(struct device *dev, struct device *iommu_device);
>> struct device *mdev_get_iommu_device(struct device *dev);
>>
>> /**
>> - * struct mdev_parent_ops - Structure to be registered for each parent device to
>> - * register the device to mdev module.
>> + * struct vfio_mdev_parent_ops - Structure to be registered for each
>> + * parent device to register the device to vfio-mdev module.
>> *
>> - * @owner: The module owner.
>> - * @dev_attr_groups: Attributes of the parent device.
>> - * @mdev_attr_groups: Attributes of the mediated device.
>> - * @supported_type_groups: Attributes to define supported types. It is mandatory
>> - * to provide supported types.
>> - * @create: Called to allocate basic resources in parent device's
>> - * driver for a particular mediated device. It is
>> - * mandatory to provide create ops.
>> - * @kobj: kobject of type for which 'create' is called.
>> - * @mdev: mdev_device structure on of mediated device
>> - * that is being created
>> - * Returns integer: success (0) or error (< 0)
>> - * @remove: Called to free resources in parent device's driver for a
>> - * a mediated device. It is mandatory to provide 'remove'
>> - * ops.
>> - * @mdev: mdev_device device structure which is being
>> - * destroyed
>> - * Returns integer: success (0) or error (< 0)
>> * @open: Open mediated device.
>> * @mdev: mediated device.
>> * Returns integer: success (0) or error (< 0)
>> @@ -72,6 +54,43 @@ struct device *mdev_get_iommu_device(struct device *dev);
>> * @mmap: mmap callback
>> * @mdev: mediated device structure
>> * @vma: vma structure
>> + */
>> +struct vfio_mdev_parent_ops {
>> + int (*open)(struct mdev_device *mdev);
>> + void (*release)(struct mdev_device *mdev);
>> + ssize_t (*read)(struct mdev_device *mdev, char __user *buf,
>> + size_t count, loff_t *ppos);
>> + ssize_t (*write)(struct mdev_device *mdev, const char __user *buf,
>> + size_t count, loff_t *ppos);
>> + long (*ioctl)(struct mdev_device *mdev, unsigned int cmd,
>> + unsigned long arg);
>> + int (*mmap)(struct mdev_device *mdev, struct vm_area_struct *vma);
>> +};
>> +
>> +/**
>> + * struct mdev_parent_ops - Structure to be registered for each parent device to
>> + * register the device to mdev module.
>> + *
>> + * @owner: The module owner.
>> + * @dev_attr_groups: Attributes of the parent device.
>> + * @mdev_attr_groups: Attributes of the mediated device.
>> + * @supported_type_groups: Attributes to define supported types. It is mandatory
>> + * to provide supported types.
>> + * @create: Called to allocate basic resources in parent device's
>> + * driver for a particular mediated device. It is
>> + * mandatory to provide create ops.
>> + * @kobj: kobject of type for which 'create' is called.
>> + * @mdev: mdev_device structure on of mediated device
>> + * that is being created
>> + * Returns integer: success (0) or error (< 0)
>> + * @remove: Called to free resources in parent device's driver for a
>> + * a mediated device. It is mandatory to provide 'remove'
>> + * ops.
>> + * @mdev: mdev_device device structure which is being
>> + * destroyed
>> + * Returns integer: success (0) or error (< 0)
>> + * @device_ops: Device specific emulation callback.
>> + *
>> * Parent device that support mediated device should be registered with mdev
>> * module with mdev_parent_ops structure.
>> **/
>> @@ -83,15 +102,7 @@ struct mdev_parent_ops {
>>
>> int (*create)(struct kobject *kobj, struct mdev_device *mdev);
>> int (*remove)(struct mdev_device *mdev);
>> - int (*open)(struct mdev_device *mdev);
>> - void (*release)(struct mdev_device *mdev);
>> - ssize_t (*read)(struct mdev_device *mdev, char __user *buf,
>> - size_t count, loff_t *ppos);
>> - ssize_t (*write)(struct mdev_device *mdev, const char __user *buf,
>> - size_t count, loff_t *ppos);
>> - long (*ioctl)(struct mdev_device *mdev, unsigned int cmd,
>> - unsigned long arg);
>> - int (*mmap)(struct mdev_device *mdev, struct vm_area_struct *vma);
>> + const void *device_ops;
>> };
>>
>> /* interface for exporting mdev supported type attributes */
> This basically looks like a split between stuff that is always
> triggered from userspace (create and the like) and stuff that is
> triggered from userspace for vfio mdevs, but not necessarily for other
> mdevs.
Yes.
> Seems reasonable at a glance.
>
> If we decide to go forward with this, we should also update the
> documentation (split out stuff from driver-api/vfio-mediated-device.rst
> etc.)
Yes, I plan to do that.
Thanks
Powered by blists - more mailing lists