linux-kernel - Re: [GIT PULL] LED updates for 5.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgxNj_RBpE0xRYnMQ9W6PtyLx+LS+pZ_BqG31vute1iAg@mail.gmail.com>
Date:   Tue, 17 Sep 2019 18:13:09 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org, ada@...rsis.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        christophe.jaillet@...adoo.fr, dmurphy@...com,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>, info@...ux.net,
        Joe Perches <joe@...ches.com>, kw@...ux.com,
        Linus Walleij <linus.walleij@...aro.org>,
        nishkadg.linux@...il.com, nstoughton@...itech.com, oleg@....org.ua,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Tony Lindgren <tony@...mide.com>, wenwen@...uga.edu,
        wsa+renesas@...g-engineering.com,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [GIT PULL] LED updates for 5.4-rc1

On Mon, Sep 16, 2019 at 3:21 PM Jacek Anaszewski
<jacek.anaszewski@...il.com> wrote:
>
> There is one merge of tag with generic_lookup_helpers since
> LED class has been made using class_find_device_by_name() helper:
>
>     Merge tag 'generic_lookup_helpers' into for-next
>     platform: Add platform_find_device_by_driver() helper
>     drivers: Add generic helper to match any device
>     drivers: Introduce device lookup variants by ACPI_COMPANION device
>     drivers: Introduce device lookup variants by device type
>     drivers: Introduce device lookup variants by fwnode
>     drivers: Introduce device lookup variants by of_node
>     drivers: Introduce device lookup variants by name

So this is fine and I've pulled it, but I have to say that I
absolutely detest how this device.h header keeps just growing
endlessly:

  [torvalds@...ux]$ wc include/linux/device.h
   1921  8252 66021 include/linux/device.h

that's almost 2k of header file, and it's included a _lot_:

  [torvalds@...ux]$ git grep include.*linux/device.h | wc
   2518    5085  144875

and many of those includes are actually from other core header files,
so it's effectively included from even more trees.

Yes, yes, many of those 2k lines are comments. But still... Do we
really want to have that humongous 65kB, 2kloc header file, and keep
growing it forever?

Greg?

                  Linus