linux-kernel - Re: [PATCH] drm/msm: Remove unused function arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Sep 2019 18:22:06 -0700
From:   Rob Clark <robdclark@...il.com>
To:     Jordan Crouse <jcrouse@...eaurora.org>
Cc:     Drew Davenport <ddavenport@...omium.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Sean Paul <sean@...rly.run>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...ux.ie>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        Sravanthi Kollukuduru <skolluku@...eaurora.org>,
        Enrico Weigelt <info@...ux.net>,
        Bruce Wang <bzwang@...omium.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Brian Masney <masneyb@...tation.org>,
        Jonathan Marek <jonathan@...ek.ca>,
        Georgi Djakov <georgi.djakov@...aro.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        Mamta Shukla <mamtashukla555@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH] drm/msm: Remove unused function arguments

On Tue, Sep 17, 2019 at 10:14 AM Jordan Crouse <jcrouse@...eaurora.org> wrote:
>
> On Mon, Sep 16, 2019 at 01:34:55PM -0700, Rob Clark wrote:
> > On Mon, Sep 16, 2019 at 1:12 PM Drew Davenport <ddavenport@...omium.org> wrote:
> > >
> > > The arguments related to IOMMU port name have been unused since
> > > commit 944fc36c31ed ("drm/msm: use upstream iommu") and can be removed.
> > >
> > > Signed-off-by: Drew Davenport <ddavenport@...omium.org>
> > > ---
> > > Rob, in the original commit the port name stuff was left intentionally.
> > > Would it be alright to remove it now?
> >
> > Upstream support for snapdragon has improved considerably since then,
> > it's been at least a couple years since I've had to backport drm to a
> > downstream android vendor kernel.  (And I think the downstream vendor
> > kernel is getting closer to upstream.)  So I think we can drop things
> > that were originally left in place to simplify backporting to vendor
> > kernel.
>
> Downstream has gotten close enough to the IOMMU API over the last few LTS
> cycles and nearly everything outside of a2xx that can work on a modern
> kernel will likely be using a arm-smmu-v2 or a MMU-500.  This code can happily
> go.
>
> > (Also, some of the regulator usage falls into this category.. at one
> > point the downstream kernel modeled gdsc's as regulators, but upstream
> > uses genpd.)
>
> Downstream still uses regulators. If we ever needed to use a downstream kernel
> for whatever reason we could easily hack them back in but I don't feel like this
> is a likely scenario.

ok, maybe we can keep the regulator cruft for a bit longer until
downstream moves to genpd.. with dummy-regulator, it doesn't really
hurt anything.

Do let me know if future downstream rebase moves to genpd, I suppose
after the next LTS after that would be a good time to garbage-collect
the regulator related gdsc management

BR,
-R