linux-kernel - Re: [GIT PULL] LED updates for 5.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wjm422bg+ZPuKkjU6NffbAyysY2n8iLRFyiNKin4cvWgg@mail.gmail.com>
Date:   Tue, 17 Sep 2019 18:40:33 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        linux-leds@...r.kernel.org, ada@...rsis.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        christophe.jaillet@...adoo.fr, dmurphy@...com,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>, info@...ux.net,
        Joe Perches <joe@...ches.com>, kw@...ux.com,
        Linus Walleij <linus.walleij@...aro.org>,
        nishkadg.linux@...il.com, nstoughton@...itech.com, oleg@....org.ua,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Tony Lindgren <tony@...mide.com>, wenwen@...uga.edu,
        wsa+renesas@...g-engineering.com,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [GIT PULL] LED updates for 5.4-rc1

On Tue, Sep 17, 2019 at 6:14 PM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Famous last words. I now get a new warning:
>
> drivers/i2c/i2c-core-acpi.c:347:12: warning:
> ‘i2c_acpi_find_match_adapter’ defined but not used [-Wunused-function]

Commit 00500147cbd3 ("drivers: Introduce device lookup variants by
ACPI_COMPANION device") removed the use of that matching function, but
didn't remove the function.

It also removed the use of i2c_acpi_find_match_device(), but in that
case it _did_ remove the function.

And apparently nobody bothers checking warnings. Tssk tssk.

                Linus