linux-kernel - Re: [PATCH] arch/microblaze: support get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2dd46339-5d69-be42-e41f-510e68503ec9@monstr.eu>
Date:   Wed, 18 Sep 2019 09:49:14 +0200
From:   Michal Simek <monstr@...str.eu>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Al Viro <viro@...IV.linux.org.uk>,
        "Steven J. Magnani" <steve@...idescorp.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH] arch/microblaze: support get_user() of size 8 bytes

On 17. 09. 19 3:39, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> arch/microblaze/ is missing support for get_user() of size 8 bytes,
> so add it by using __copy_from_user().
> 
> While there, also drop a lot of the code duplication.
> 
> Fixes these build errors:
>    drivers/infiniband/core/uverbs_main.o: In function `ib_uverbs_write':
>    drivers/infiniband/core/.tmp_gl_uverbs_main.o:(.text+0x13a4): undefined reference to `__user_bad'
>    drivers/android/binder.o: In function `binder_thread_write':
>    drivers/android/.tmp_gl_binder.o:(.text+0xda6c): undefined reference to `__user_bad'
>    drivers/android/.tmp_gl_binder.o:(.text+0xda98): undefined reference to `__user_bad'
>    drivers/android/.tmp_gl_binder.o:(.text+0xdf10): undefined reference to `__user_bad'
>    drivers/android/.tmp_gl_binder.o:(.text+0xe498): undefined reference to `__user_bad'
>    drivers/android/binder.o:drivers/android/.tmp_gl_binder.o:(.text+0xea78): more undefined references to `__user_bad' follow
> 
> 'make allmodconfig' now builds successfully for arch/microblaze/.
> 
> Fixes: 538722ca3b76 ("microblaze: fix get_user/put_user side-effects")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Acked-by: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Al Viro <viro@...iv.linux.org.uk>
> Cc: Steven J. Magnani <steve@...idescorp.com>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Jason Gunthorpe <jgg@...lanox.com>
> Cc: Leon Romanovsky <leonro@...lanox.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Doug Ledford <dledford@...hat.com>
> ---
> v4: drop code duplication (Linus).
> 
> 
>  arch/microblaze/include/asm/uaccess.h |   42 +++++-------------------
>  1 file changed, 9 insertions(+), 33 deletions(-)
> 
> --- lnx-53.orig/arch/microblaze/include/asm/uaccess.h
> +++ lnx-53/arch/microblaze/include/asm/uaccess.h
> @@ -163,44 +163,15 @@ extern long __user_bad(void);
>   * Returns zero on success, or -EFAULT on error.
>   * On error, the variable @x is set to zero.
>   */
> -#define get_user(x, ptr)						\
> -	__get_user_check((x), (ptr), sizeof(*(ptr)))
> -
> -#define __get_user_check(x, ptr, size)					\
> -({									\
> -	unsigned long __gu_val = 0;					\
> -	const typeof(*(ptr)) __user *__gu_addr = (ptr);			\
> -	int __gu_err = 0;						\
> -									\
> -	if (access_ok(__gu_addr, size)) {			\
> -		switch (size) {						\
> -		case 1:							\
> -			__get_user_asm("lbu", __gu_addr, __gu_val,	\
> -				       __gu_err);			\
> -			break;						\
> -		case 2:							\
> -			__get_user_asm("lhu", __gu_addr, __gu_val,	\
> -				       __gu_err);			\
> -			break;						\
> -		case 4:							\
> -			__get_user_asm("lw", __gu_addr, __gu_val,	\
> -				       __gu_err);			\
> -			break;						\
> -		default:						\
> -			__gu_err = __user_bad();			\
> -			break;						\
> -		}							\
> -	} else {							\
> -		__gu_err = -EFAULT;					\
> -	}								\
> -	x = (__force typeof(*(ptr)))__gu_val;				\
> -	__gu_err;							\
> +#define get_user(x, ptr) ({				\
> +	const typeof(*(ptr)) __user *__gu_ptr = (ptr);	\
> +	access_ok(__gu_ptr, sizeof(*__gu_ptr)) ?	\
> +		__get_user(x, __gu_ptr) : -EFAULT;	\
>  })
>  
>  #define __get_user(x, ptr)						\
>  ({									\
>  	unsigned long __gu_val = 0;					\
> -	/*unsigned long __gu_ptr = (unsigned long)(ptr);*/		\
>  	long __gu_err;							\
>  	switch (sizeof(*(ptr))) {					\
>  	case 1:								\
> @@ -212,6 +183,11 @@ extern long __user_bad(void);
>  	case 4:								\
>  		__get_user_asm("lw", (ptr), __gu_val, __gu_err);	\
>  		break;							\
> +	case 8:								\
> +		__gu_err = __copy_from_user(&__gu_val, ptr, 8);		\
> +		if (__gu_err)						\
> +			__gu_err = -EFAULT;				\
> +		break;							\
>  	default:							\
>  		/* __gu_val = 0; __gu_err = -EINVAL;*/ __gu_err = __user_bad();\
>  	}								\
> 
> 

Applied.

Thanks,
Michal





Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)