linux-kernel - Re: [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPfsUw-+yRc=GF+t=1pE7D3dF_wpRUwZpmfLnRbDyEmKeQ@mail.gmail.com>
Date:   Wed, 18 Sep 2019 13:26:29 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Mark Rutland <mark.rutland@....com>,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Convert Samsung SoC watchdog
 bindings to json-schema

On Fri, 13 Sep 2019 at 16:36, Rob Herring <robh@...nel.org> wrote:
>
> On Sat, Sep 07, 2019 at 04:45:40PM +0200, Krzysztof Kozlowski wrote:
> > Convert Samsung S3C/S5P/Exynos watchdog bindings to DT schema format
> > using json-schema.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> > ---
> >  .../bindings/watchdog/samsung-wdt.txt         | 35 ----------
> >  .../bindings/watchdog/samsung-wdt.yaml        | 69 +++++++++++++++++++
> >  2 files changed, 69 insertions(+), 35 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
> >  create mode 100644 Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
>
>
> > diff --git a/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > new file mode 100644
> > index 000000000000..39f1ca3bc4db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/samsung-wdt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Samsung SoC Watchdog Timer Controller
> > +
> > +maintainers:
> > +  - Krzysztof Kozlowski <krzk@...nel.org>
> > +
> > +description: |+
> > +  The Samsung's Watchdog controller is used for resuming system operation
> > +  after a preset amount of time during which the WDT reset event has not
> > +  occurred.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - samsung,s3c2410-wdt                   # for S3C2410
> > +      - samsung,s3c6410-wdt                   # for S3C6410, S5PV210 and Exynos4
> > +      - samsung,exynos5250-wdt                # for Exynos5250
> > +      - samsung,exynos5420-wdt                # for Exynos5420
> > +      - samsung,exynos7-wdt                   # for Exynos7
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  samsung,syscon-phandle:
> > +    $ref: '/schemas/types.yaml#/definitions/phandle'
> > +    description:
> > +      Phandle to the PMU system controller node (in case of Exynos5250
> > +      and Exynos5420).
> > +
> > +  timeout-sec:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      Watchdog timeout in seconds.
>
> We need a common schema for this and the node name.

Common schema in dt-schema or in Linux kernel bindings? If the latter,
I can add it.

> Also note that anything with a unit suffix already has a type
> definition, so we don't really need to define it again.

Right.

Best regards,
Krzysztof