linux-kernel - Re: [PATCH v2 1/1] platform/x86/intel_cht_int33fe: Split code to USB TypeB and TypeC variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Sep 2019 14:38:35 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Yauhen Kharuzhy <jekhor@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>,
        linux-kernel@...r.kernel.org, Andy Shevchenko <andy@...radead.org>
Subject: Re: [PATCH v2 1/1] platform/x86/intel_cht_int33fe: Split code to USB
 TypeB and TypeC variants

On Tue, Sep 17, 2019 at 10:45:07PM +0300, Yauhen Kharuzhy wrote:
> Existing intel_cht_int33fe ACPI pseudo-device driver assumes that
> hardware has TypeC connector and register related devices described as
> I2C connections in the _CRS resource.
> 
> There is at least one hardware (Lenovo Yoga Book YB1-91L/F) with micro
> USB B connector exists. It has INT33FE device in the DSDT table but
> there are only two I2C connection described: PMIC and BQ27452 battery
> fuel gauge.
> 
> Splitting existing INT33FE driver allow to maintain code for USB type B
> (AB) connector variant separately and make it simpler.

Sorry, but "Type B" is even more confusing here. Type B refers to the
Standard-B USB connector, so _not_ the micro connector family. You can
check the connector definitions from the latest USB 3.2 specification.
The standard-b definition goes something like this:

        "The standard _Type-B_ connector defined by the USB x specification."

Note that all the five supported connectors are listed in ch5
"Mechanical":

        Standard-A
        Standard-B
        Micro-B
        Micro-AB
        Type-C

So what was the problem with names that refer to the micro connector
family, for example "micro-ab" or "micro-b"?


thanks,

-- 
heikki