[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1568824231-4007-1-git-send-email-allen.pais@oracle.com>
Date: Wed, 18 Sep 2019 22:00:31 +0530
From: Allen Pais <allen.pais@...cle.com>
To: dri-devel@...ts.freedesktop.org
Cc: airlied@...ux.ie, linux-kernel@...r.kernel.org,
amd-gfx@...ts.freedesktop.org, daniel@...ll.ch
Subject: [PATCH] drm/amdkfd: fix a potential NULL pointer dereference
alloc_workqueue is not checked for errors and as a result,
a potential NULL dereference could occur.
Signed-off-by: Allen Pais <allen.pais@...cle.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
index c56ac47..caa82a8 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_interrupt.c
@@ -62,6 +62,11 @@ int kfd_interrupt_init(struct kfd_dev *kfd)
}
kfd->ih_wq = alloc_workqueue("KFD IH", WQ_HIGHPRI, 1);
+ if (unlikely(!kfd->ih_wq)) {
+ fifo_free(&kfd->ih_fifo);
+ dev_err(kfd_chardev(), "Failed to allocate KFD IH workqueue\n");
+ return kfd->ih_wq;
+ }
spin_lock_init(&kfd->interrupt_lock);
INIT_WORK(&kfd->interrupt_work, interrupt_wq);
--
1.9.1
Powered by blists - more mailing lists