linux-kernel - Re: [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <905f43fb-b75c-d0f2-8669-275e18241735@ti.com>
Date:   Wed, 18 Sep 2019 13:48:06 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Guido Günther <agx@...xcpu.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, <linux-leds@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL

Guido

On 9/17/19 9:19 PM, Guido Günther wrote:
> Use LM3692X_RAMP_EN instead of LM3692X_PWM_HYSTER_4LSB
> since the later is a flag for the PWM register. The
> actual register value remains unchanged.
>
> Signed-off-by: Guido Günther <agx@...xcpu.org>
Reviewed-by: Dan Murphy <dmurphy@...com>
> ---
>   drivers/leds/leds-lm3692x.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
> index d673f706385e..ecac586ca89c 100644
> --- a/drivers/leds/leds-lm3692x.c
> +++ b/drivers/leds/leds-lm3692x.c
> @@ -269,7 +269,7 @@ static int lm3692x_init(struct lm3692x_led *led)
>   		goto out;
>   
>   	ret = regmap_write(led->regmap, LM3692X_BRT_CTRL,
> -			LM3692X_BL_ADJ_POL | LM3692X_PWM_HYSTER_4LSB);
> +			LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN);
>   	if (ret)
>   		goto out;
>