[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1568861888-34045-3-git-send-email-nixiaoming@huawei.com>
Date: Thu, 19 Sep 2019 10:58:07 +0800
From: Xiaoming Ni <nixiaoming@...wei.com>
To: <gregkh@...uxfoundation.org>, <akpm@...ux-foundation.org>,
<vvs@...tuozzo.com>, <torvalds@...ux-foundation.org>,
<adobriyan@...il.com>, <anna.schumaker@...app.com>,
<arjan@...ux.intel.com>, <bfields@...ldses.org>,
<chuck.lever@...cle.com>, <davem@...emloft.net>,
<jlayton@...nel.org>, <luto@...nel.org>, <mingo@...nel.org>,
<Nadia.Derbey@...l.net>, <paulmck@...ux.vnet.ibm.com>,
<semen.protsenko@...aro.org>, <stern@...land.harvard.edu>,
<tglx@...utronix.de>, <trond.myklebust@...merspace.com>,
<viresh.kumar@...aro.org>
CC: <stable@...nel.org>, <dylix.dailei@...wei.com>,
<nixiaoming@...wei.com>, <yuehaibing@...wei.com>,
<linux-kernel@...r.kernel.org>, <linux-nfs@...r.kernel.org>,
<netdev@...r.kernel.org>
Subject: [PATCH v4 2/3] kernel/notifier.c: remove notifier_chain_cond_register()
The only difference between notifier_chain_cond_register() and
notifier_chain_register() is the lack of warning hints for duplicate
registrations.
Consider using notifier_chain_register() instead of
notifier_chain_cond_register() to avoid duplicate code
Signed-off-by: Xiaoming Ni <nixiaoming@...wei.com>
---
kernel/notifier.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/kernel/notifier.c b/kernel/notifier.c
index 30bedb8..e3d221f 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -36,21 +36,6 @@ static int notifier_chain_register(struct notifier_block **nl,
return 0;
}
-static int notifier_chain_cond_register(struct notifier_block **nl,
- struct notifier_block *n)
-{
- while ((*nl) != NULL) {
- if ((*nl) == n)
- return 0;
- if (n->priority > (*nl)->priority)
- break;
- nl = &((*nl)->next);
- }
- n->next = *nl;
- rcu_assign_pointer(*nl, n);
- return 0;
-}
-
static int notifier_chain_unregister(struct notifier_block **nl,
struct notifier_block *n)
{
@@ -252,7 +237,7 @@ int blocking_notifier_chain_cond_register(struct blocking_notifier_head *nh,
int ret;
down_write(&nh->rwsem);
- ret = notifier_chain_cond_register(&nh->head, n);
+ ret = notifier_chain_register(&nh->head, n);
up_write(&nh->rwsem);
return ret;
}
--
1.8.5.6
Powered by blists - more mailing lists