linux-kernel - Re: [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Sep 2019 07:17:44 +0000
From:   Schrempf Frieder <frieder.schrempf@...tron.de>
To:     Anson Huang <Anson.Huang@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "leonard.crestez@....com" <leonard.crestez@....com>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "ping.bai@....com" <ping.bai@....com>,
        "daniel.baluta@....com" <daniel.baluta@....com>,
        "jun.li@....com" <jun.li@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "abel.vesa@....com" <abel.vesa@....com>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "angus@...ea.ca" <angus@...ea.ca>,
        "ccaione@...libre.com" <ccaione@...libre.com>,
        "agx@...xcpu.org" <agx@...xcpu.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Linux-imx@....com" <Linux-imx@....com>
Subject: Re: [PATCH 2/3] arm64: dts: imx8mm: Use correct clock for usdhc's ipg
 clk

Hi Anson,

I have a question, that is not directly related to this patch.
I see that for the usdhc1 and usdhc3 nodes, there is an 'assigned-clock' 
and 'assigned-clock-rates' property but not for usdhc2. The same applies 
to the mx8mq and mx8mn dtsi file.

Is there any reason for this? If not can you fix it?

Thanks,
Frieder

On 19.09.19 07:05, Anson Huang wrote:
> On i.MX8MM, usdhc's ipg clock is from IMX8MM_CLK_IPG_ROOT,
> assign it explicitly instead of using IMX8MM_CLK_DUMMY.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>   arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 7c4dcce..8aafad2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -694,7 +694,7 @@
>   				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
>   				reg = <0x30b40000 0x10000>;
>   				interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MM_CLK_DUMMY>,
> +				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
>   					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
>   					 <&clk IMX8MM_CLK_USDHC1_ROOT>;
>   				clock-names = "ipg", "ahb", "per";
> @@ -710,7 +710,7 @@
>   				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
>   				reg = <0x30b50000 0x10000>;
>   				interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MM_CLK_DUMMY>,
> +				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
>   					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
>   					 <&clk IMX8MM_CLK_USDHC2_ROOT>;
>   				clock-names = "ipg", "ahb", "per";
> @@ -724,7 +724,7 @@
>   				compatible = "fsl,imx8mm-usdhc", "fsl,imx7d-usdhc";
>   				reg = <0x30b60000 0x10000>;
>   				interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk IMX8MM_CLK_DUMMY>,
> +				clocks = <&clk IMX8MM_CLK_IPG_ROOT>,
>   					 <&clk IMX8MM_CLK_NAND_USDHC_BUS>,
>   					 <&clk IMX8MM_CLK_USDHC3_ROOT>;
>   				clock-names = "ipg", "ahb", "per";
>