linux-kernel - Re: [PATCH] platform/x86: pmc_atom: Add Siemens SIMATIC IPC2x7E to critclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e511b90-314d-1724-a046-d2efe26b3b96@siemens.com>
Date:   Thu, 19 Sep 2019 09:56:08 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Srikanth Krishnakar <skrishnakar@...il.com>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        dvhart@...radead.org, andy@...radead.org
Cc:     Cedric_Hombourger@...tor.com, Srikanth_Krishnakar@...tor.com
Subject: Re: [PATCH] platform/x86: pmc_atom: Add Siemens SIMATIC IPC2x7E to
 critclk_systems DMI table

On 19.09.19 09:45, Srikanth Krishnakar wrote:
> The SIMATIC IPC227E and IPC277E uses the PMC clock for on-board components
> and gets stuck during boot if the clock is disabled. Therefore, add this
> device to the critical systems list.
> 
> The Board revision does vary in some instances and hence use PRODUCT_NAME
> to allow the boards to boot with identical names.
> 
> Tested on SIMATIC IPC227E and IPC277E.
> 
> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> CC: Jan Kiszka <jan.kiszka@...mens.com>
> CC: Cedric Hombourger <Cedric_Hombourger@...tor.com>
> Signed-off-by: Srikanth Krishnakar <Srikanth_Krishnakar@...tor.com>
> ---
>   drivers/platform/x86/pmc_atom.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 9aca5e7ce6d0..1e48c2ec684e 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -419,7 +419,14 @@ static const struct dmi_system_id critclk_systems[] = {
>   		.ident = "SIMATIC IPC227E",
>   		.matches = {
>   			DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> -			DMI_MATCH(DMI_PRODUCT_VERSION, "6ES7647-8B"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "SIMATIC IPC227E"),

NACK, this is breaking platform variant detection.

> +		},
> +	},
> +	{
> +		.ident = "SIMATIC IPC277E",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "SIMATIC IPC277E"),

Let us clarify internally if we need to match on the same substring length as 
for the 227E.

Jan

>   		},
>   	},
>   	{ /*sentinel*/ }
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux