linux-kernel - Re: [PATCH 1/1] sched/eas: introduce system-wide overutil indicator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201909191621.sgTOlkMo%lkp@intel.com>
Date:   Thu, 19 Sep 2019 16:10:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     YT Chang <yt.chang@...iatek.com>
Cc:     kbuild-all@...org, Peter Zijlstra <peterz@...radead.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        wsd_upstream@...iatek.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        YT Chang <yt.chang@...iatek.com>
Subject: Re: [PATCH 1/1] sched/eas: introduce system-wide overutil indicator

Hi YT,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/YT-Chang/sched-eas-introduce-system-wide-overutil-indicator/20190919-152213
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'update_system_overutilized':
>> kernel/sched/fair.c:5234:20: error: 'capacity_margin' undeclared (first use in this function); did you mean 'capacity_of'?
          group_util * capacity_margin)) {
                       ^~~~~~~~~~~~~~~
                       capacity_of
   kernel/sched/fair.c:5234:20: note: each undeclared identifier is reported only once for each function it appears in

vim +5234 kernel/sched/fair.c

  5195	
  5196	static
  5197	void update_system_overutilized(struct sched_domain *sd, struct cpumask *cpus)
  5198	{
  5199		unsigned long group_util;
  5200		bool intra_overutil = false;
  5201		unsigned long max_capacity;
  5202		struct sched_group *group = sd->groups;
  5203		struct root_domain *rd;
  5204		int this_cpu;
  5205		bool overutilized;
  5206		int i;
  5207	
  5208		this_cpu = smp_processor_id();
  5209		rd = cpu_rq(this_cpu)->rd;
  5210		overutilized = READ_ONCE(rd->overutilized);
  5211		max_capacity = rd->max_cpu_capacity;
  5212	
  5213		do {
  5214			group_util = 0;
  5215			for_each_cpu_and(i, sched_group_span(group), cpus) {
  5216				group_util += cpu_util(i);
  5217				if (cpu_overutilized(i)) {
  5218					if (capacity_orig_of(i) < max_capacity) {
  5219						intra_overutil = true;
  5220						break;
  5221					}
  5222				}
  5223			}
  5224	
  5225			/*
  5226			 * A capacity base hint for over-utilization.
  5227			 * Not to trigger system overutiled if heavy tasks
  5228			 * in Big.cluster, so
  5229			 * add the free room(20%) of Big.cluster is impacted which means
  5230			 * system-wide over-utilization,
  5231			 * that considers whole cluster not single cpu
  5232			 */
  5233			if (group->group_weight > 1 && (group->sgc->capacity * 1024 <
> 5234							group_util * capacity_margin)) {
  5235				intra_overutil = true;
  5236				break;
  5237			}
  5238	
  5239			group = group->next;
  5240	
  5241		} while (group != sd->groups && !intra_overutil);
  5242	
  5243		if (overutilized != intra_overutil) {
  5244			if (intra_overutil == true) {
  5245				WRITE_ONCE(rd->overutilized, SG_OVERUTILIZED);
  5246				trace_sched_overutilized_tp(rd, SG_OVERUTILIZED);
  5247			} else {
  5248				WRITE_ONCE(rd->overutilized, 0);
  5249				trace_sched_overutilized_tp(rd, 0);
  5250			}
  5251		}
  5252	}
  5253	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28088 bytes)