linux-kernel - RE: [PATCH] scsi: qedf: Remove always false 'tmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB252777FF9E6A250332E70661D2890@MN2PR18MB2527.namprd18.prod.outlook.com>
Date:   Thu, 19 Sep 2019 08:52:11 +0000
From:   Saurav Kashyap <skashyap@...vell.com>
To:     Austin Kim <austindh.kim@...il.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "QLogic-Storage-Upstream@...ium.com" 
        <QLogic-Storage-Upstream@...ium.com>
Subject: RE: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement



> -----Original Message-----
> From: linux-scsi-owner@...r.kernel.org <linux-scsi-owner@...r.kernel.org> On
> Behalf Of Austin Kim
> Sent: Thursday, September 19, 2019 1:26 PM
> To: jejb@...ux.ibm.com; martin.petersen@...cle.com
> Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; QLogic-Storage-
> Upstream@...ium.com; austindh.kim@...il.com
> Subject: [PATCH] scsi: qedf: Remove always false 'tmp_prio < 0' statement
> 
> Since tmp_prio is declared as u8, the following statement is always false.
>    tmp_prio < 0
> 
> So remove 'always false' statement.
> 
> Signed-off-by: Austin Kim <austindh.kim@...il.com>
> ---
>  drivers/scsi/qedf/qedf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index
> 1659d35..59ca98f 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -596,7 +596,7 @@ static void qedf_dcbx_handler(void *dev, struct
> qed_dcbx_get *get, u32 mib_type)
>  		tmp_prio = get->operational.app_prio.fcoe;
>  		if (qedf_default_prio > -1)
>  			qedf->prio = qedf_default_prio;
> -		else if (tmp_prio < 0 || tmp_prio > 7) {
> +		else if (tmp_prio > 7) {
>  			QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC,
>  			    "FIP/FCoE prio %d out of range, setting to %d.\n",
>  			    tmp_prio, QEDF_DEFAULT_PRIO);
> --
> 2.6.2

Hi Austin,
Thanks for the patch.

Acked-by: Saurav Kashyap <skashyap@...vell.com>