linux-kernel - Re: [PATCH] platform/chrome: null check create_singlethread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Sep 2019 15:06:40 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     emamd001@....edu, smccaman@....edu, kjlu@....edu,
        Benson Leung <bleung@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/chrome: null check create_singlethread_workqueue

Hi,

On 11/9/19 22:10, Navid Emamdoost wrote:
> In cros_usbpd_logger_probe the return value of
> create_singlethread_workqueue may be null, it should be checked.
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
> ---

Applied for 5.4, the patch went to linux-next some time ago, so sorry for late
notice.

Thanks,
 Enric


>  drivers/platform/chrome/cros_usbpd_logger.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
> index 7c7b267626a0..c83397955cc3 100644
> --- a/drivers/platform/chrome/cros_usbpd_logger.c
> +++ b/drivers/platform/chrome/cros_usbpd_logger.c
> @@ -209,6 +209,9 @@ static int cros_usbpd_logger_probe(struct platform_device *pd)
>  	/* Retrieve PD event logs periodically */
>  	INIT_DELAYED_WORK(&logger->log_work, cros_usbpd_log_check);
>  	logger->log_workqueue =	create_singlethread_workqueue("cros_usbpd_log");
> +	if (!logger->log_workqueue)
> +		return -ENOMEM;
> +
>  	queue_delayed_work(logger->log_workqueue, &logger->log_work,
>  			   CROS_USBPD_LOG_UPDATE_DELAY);
>  
>