linux-kernel - Re: [PATCH 2/2] crypto: hisilicon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Sep 2019 23:48:13 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Zhou Wang <wangzhou1@...ilicon.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Hao Fang <fanghao11@...wei.com>,
        Kenneth Lee <liguozhu@...ilicon.com>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] crypto: hisilicon - avoid unused function warning

On Thu, Sep 19, 2019 at 04:11:13PM +0800, Zhou Wang wrote:
> On 2019/9/13 17:17, Herbert Xu wrote:
> > On Fri, Sep 06, 2019 at 05:22:30PM +0200, Arnd Bergmann wrote:
> >> The only caller of hisi_zip_vf_q_assign() is hidden in an #ifdef,
> >> so the function causes a warning when CONFIG_PCI_IOV is disabled:
> >>
> >> drivers/crypto/hisilicon/zip/zip_main.c:740:12: error: unused function 'hisi_zip_vf_q_assign' [-Werror,-Wunused-function]
> >>
> >> Move it into the same #ifdef.
> >>
> >> Fixes: 79e09f30eeba ("crypto: hisilicon - add SRIOV support for ZIP")
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >> ---
> >>  drivers/crypto/hisilicon/zip/zip_main.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> > 
> > Please find a way to fix this warning without reducing compiler
> > coverage.  I prefer to see any compile issues immediately rather
> > than through automated build testing.
> > 
> > Thanks,
> >
> 
> Sorry for missing this patch.
> 
> Seems other drivers also do like using #ifdef. Do you mean something like this:
> #ifdef CONFIG_PCI_IOV
> sriov_enable()
> ...
> #else
> /* stub */
> sriov_enable()
> ...
> #endif

For an unused warning the unused compiler attribute would seem
to be the way to go.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt