linux-kernel - Re: [PATCH 4/9] select: Micro-optimise __estimate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ba601dc-4ee5-7381-d9ce-e1a56fbc1653@gmail.com>
Date:   Thu, 19 Sep 2019 15:25:46 +0100
From:   Dmitry Safonov <0x7f454c46@...il.com>
To:     Cyrill Gorcunov <gorcunov@...il.com>,
        Dmitry Safonov <dima@...sta.com>
Cc:     linux-kernel@...r.kernel.org, Adrian Reber <adrian@...as.de>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrei Vagin <avagin@...nvz.org>,
        Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Oleg Nesterov <oleg@...hat.com>,
        Pavel Emelyanov <xemul@...tuozzo.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        containers@...ts.linux-foundation.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 4/9] select: Micro-optimise __estimate_accuracy()

On 9/19/19 3:05 PM, Cyrill Gorcunov wrote:
[..]
>> diff --git a/fs/select.c b/fs/select.c
>> index 12cdefd3be2d..2477c202631e 100644
>> --- a/fs/select.c
>> +++ b/fs/select.c
>> @@ -51,15 +51,14 @@
>>  
>>  static long __estimate_accuracy(ktime_t slack)
>>  {
>> -	int divfactor = 1000;
>> -
>>  	if (slack < 0)
>>  		return 0;
> 
> Btw, don't you better use <= here?
> 

Good point, will do for v2.

Thanks,
          Dmitry