linux-kernel - Re: [PATCH] mtd: st_spi_fsm: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e062df64-1e13-f88d-5bef-cbc3a1a7fdf0@cogentembedded.com>
Date:   Thu, 19 Sep 2019 18:08:08 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: st_spi_fsm: remove unused variable

Hello!

On 09/19/2019 03:29 PM, Bartosz Golaszewski wrote:

> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> The region resource in struct stfsm is unused and can be removed.

   OK, except it's not a variable (as the subject says), it's a structure field.
"region resource" also seems strange...

> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>  drivers/mtd/devices/st_spi_fsm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
> index f4d1667daaf9..1888523d9745 100644
> --- a/drivers/mtd/devices/st_spi_fsm.c
> +++ b/drivers/mtd/devices/st_spi_fsm.c
> @@ -255,7 +255,6 @@ struct stfsm_seq {
>  struct stfsm {
>  	struct device		*dev;
>  	void __iomem		*base;
> -	struct resource		*region;
>  	struct mtd_info		mtd;
>  	struct mutex		lock;
>  	struct flash_info       *info;

MBR, Sergei