linux-kernel - Re: [PATCH] iwlwifi: fix a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ee2c6b1-49e3-5050-23c4-a27c152b836c@oracle.com>
Date:   Thu, 19 Sep 2019 20:59:48 +0530
From:   Allen <allen.pais@...cle.com>
To:     Johannes Berg <johannes@...solutions.net>, kvalo@...eaurora.org
Cc:     davem@...emloft.net, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: fix a potential NULL pointer dereference


>>>
>>> +	trans_pcie->rba.alloc_wq = alloc_workqueue("rb_allocator",
>>> +						   WQ_HIGHPRI | WQ_UNBOUND, 1);
>>> +	if (!trans_pcie->rba.alloc_wq) {
>>
>>     I would like to stick to if(unlikely(!trans_pcie->rba.alloc_wq) just
>> for consistency.
> 
> That's just clutter, this path gets called exactly once in the lifetime
> of most systems ...
> 
>>     Let me know if I could add your SOB and send out V2.
> 
> No no, I've already sent the patch on the way internally :)

Great. Thank you.