[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201909190918.443D6BC7@keescook>
Date: Thu, 19 Sep 2019 09:55:30 -0700
From: Kees Cook <keescook@...omium.org>
To: "Dmitry V. Levin" <ldv@...linux.org>
Cc: Tyler Hicks <tyhicks@...onical.com>,
Christian Brauner <christian.brauner@...ntu.com>,
luto@...capital.net, jannh@...gle.com, wad@...omium.org,
shuah@...nel.org, ast@...nel.org, daniel@...earbox.net,
kafai@...com, songliubraving@...com, yhs@...com,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
netdev@...r.kernel.org, bpf@...r.kernel.org,
Tycho Andersen <tycho@...ho.ws>, stable@...r.kernel.org
Subject: Re: [PATCH 2/4] seccomp: add two missing ptrace ifdefines
On Thu, Sep 19, 2019 at 01:42:51PM +0300, Dmitry V. Levin wrote:
> On Wed, Sep 18, 2019 at 10:33:09AM -0700, Kees Cook wrote:
> > This is actually fixed in -next already (and, yes, with the Fixes line
> > Tyler has mentioned):
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=69b2d3c5924273a0ae968d3818210fc57a1b9d07
>
> Excuse me, does it mean that you expect each selftest to be self-hosted?
> I was (and still is) under impression that selftests should be built
> with headers installed from the tree. Is it the case, or is it not?
As you know (but to give others some context) there is a long-standing
bug in the selftest build environment that causes these problems (it
isn't including the uAPI headers) which you'd proposed to be fixed
recently[1]. Did that ever get sent as a "real" patch? I don't see it
in Shuah's tree; can you send it to Shuah?
But even with that fixed, since the seccomp selftest has a history of
being built stand-alone, I've continued to take these kinds of fixes.
-Kees
[1] https://lore.kernel.org/lkml/20190805094719.GA1693@altlinux.org/
--
Kees Cook
Powered by blists - more mailing lists