linux-kernel - Re: [PATCH] ata: libahci_platform: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c61069af-29c0-449a-a07f-c89c5a5535fa@web.de>
Date:   Thu, 19 Sep 2019 20:17:34 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>,
        Jens Axboe <axboe@...nel.dk>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-ide@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ata: libahci_platform: Add of_node_put() before loop exit

> +++ b/drivers/ata/libahci_platform.c
> @@ -497,6 +497,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
>
>  			if (of_property_read_u32(child, "reg", &port)) {
>  				rc = -EINVAL;
> +				of_node_put(child);
>  				goto err_out;
>  			}

I suggest to move the added function call to another jump target.

-				goto err_out;
+				goto err_put_node;
 	…
+err_put_node:
 	of_node_put(child);
 err_out:
 	…


Regards,
Markus