linux-kernel - Re: [PATCH] leds-bcm63xx: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <658bd05d-376d-adfd-64a5-e20f83d7b90a@gmail.com>
Date:   Thu, 19 Sep 2019 22:35:34 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>, linux-leds@...r.kernel.org,
        Álvaro Fernández Rojas <noltari@...il.com>,
        Dan Murphy <dmurphy@...com>, Pavel Machek <pavel@....cz>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Himanshu Jha <himanshujha199640@...il.com>
Subject: Re: [PATCH] leds-bcm63xx: Use devm_platform_ioremap_resource() in two
 functions

Hi Markus,

Thank you for the patch.

Please split it to two separate ones - one per affected driver.

Best regards,
Jacek Anaszewski

On 9/18/19 10:55 AM, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 18 Sep 2019 10:45:24 +0200
> 
> Simplify these function implementations by using a known function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/leds/leds-bcm6328.c | 7 +------
>  drivers/leds/leds-bcm6358.c | 7 +------
>  2 files changed, 2 insertions(+), 12 deletions(-)