linux-kernel - Re: [PATCH] workqueue: Fix spurious sanity check failures in destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190920210833.GC2233839@devbig004.ftw2.facebook.com>
Date:   Fri, 20 Sep 2019 14:08:33 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Lai Jiangshan <jiangshanlai@...il.com>
Cc:     ~@...big004.ftw2.facebook.com, LKML <linux-kernel@...r.kernel.org>,
        kernel-team <kernel-team@...com>,
        Marcin Pawlowski <mpawlowski@...com>,
        "Williams, Gerald S" <gerald.s.williams@...el.com>
Subject: Re: [PATCH] workqueue: Fix spurious sanity check failures in
 destroy_workqueue()

Hello,

On Thu, Sep 19, 2019 at 10:49:04AM +0800, Lai Jiangshan wrote:
> Looks good to me.
> 
> There is one test in show_pwq()
> """
>  worker == pwq->wq->rescuer ? "(RESCUER)" : "",
> """
> I'm wondering if it needs to be updated to
> """
> worker->rescue_wq ? "(RESCUER)" : "",
> """

Hmm... yeah, good point.  Let's do that.

> And document "/* MD: rescue worker */" might be better
> than current "/* I: rescue worker */", although ->rescuer can
> be accessed without wq_mayday_lock lock in some code.

Will apply this one too.

Thanks.

-- 
tejun