linux-kernel - Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1909202333450.1459@cbobk.fhfr.pm>
Date:   Fri, 20 Sep 2019 23:34:04 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
cc:     Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5.1-rc] iwlwifi: make locking in iwl_mvm_tx_mpdu()
 BH-safe

On Wed, 11 Sep 2019, Jiri Kosina wrote:

> > From: Jiri Kosina <jkosina@...e.cz>
> > Subject: [PATCH] iwlwifi: make locking in iwl_mvm_tx_mpdu() BH-safe
> 
> Hm, scratch that, that might actually spuriously enable BHs if called from 
> contexts that already did disabled BHs.
> 
> So what solution would you prefer here? Just stick another par of 
> bh_disable() / bh_enable() somewhere to the wake_txs() -> 
> iwl_mvm_mac_itxq_xmit() -> iwl_mvm_tx_skb() -> iwl_mvm_tx_mpdu() path?

Ping? This seems to be still the case.

Thanks,

-- 
Jiri Kosina
SUSE Labs