linux-kernel - Re: [PATCH] platform/x86: i2c-multi-instantiate: Derive the device name from parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cde45562-af19-77e9-b3c9-7b3eb7dcd459@redhat.com>
Date:   Fri, 20 Sep 2019 12:32:22 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Andy Shevchenko <andy@...radead.org>
Cc:     Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] platform/x86: i2c-multi-instantiate: Derive the device
 name from parent

Hi,

On 9/20/19 12:02 PM, Heikki Krogerus wrote:
> When naming the new devices, instead of using the ACPI ID in
> the name as base, using the parent device's name. That makes
> it possible to support multiple multi-instance i2c devices
> of the same type in the same system.
> 
> This fixes an issue seen on some Intel Kaby Lake based
> boards:
> 
> sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-0/i2c-INT3515-tps6598x.0'
> 
> Fixes: 2336dfadfb1e ("platform/x86: i2c-multi-instantiate: Allow to have same slaves")
> Cc: stable@...r.kernel.org
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> ---
>   drivers/platform/x86/i2c-multi-instantiate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c
> index 61fe341a85aa..ea68f6ed66ae 100644
> --- a/drivers/platform/x86/i2c-multi-instantiate.c
> +++ b/drivers/platform/x86/i2c-multi-instantiate.c
> @@ -90,7 +90,7 @@ static int i2c_multi_inst_probe(struct platform_device *pdev)
>   	for (i = 0; i < multi->num_clients && inst_data[i].type; i++) {
>   		memset(&board_info, 0, sizeof(board_info));
>   		strlcpy(board_info.type, inst_data[i].type, I2C_NAME_SIZE);
> -		snprintf(name, sizeof(name), "%s-%s.%d", match->id,
> +		snprintf(name, sizeof(name), "%s-%s.%d", dev_name(dev),
>   			 inst_data[i].type, i);
>   		board_info.dev_name = name;
>   		switch (inst_data[i].flags & IRQ_RESOURCE_TYPE) {
>