linux-kernel - Re: [PATCH] jffs2:freely allocate memory when parameters are invalid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <206f8d57-dad9-26c3-6bf6-1d000f5698d4@huawei.com>
Date:   Fri, 20 Sep 2019 20:21:53 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Al Viro <viro@...iv.linux.org.uk>
CC:     <dwmw2@...radead.org>, <dilinger@...ued.net>, <richard@....at>,
        <houtao1@...wei.com>, <bbrezillon@...nel.org>,
        <daniel.santos@...ox.com>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] jffs2:freely allocate memory when parameters are invalid



On 2019/9/20 19:43, Al Viro wrote:
> On Fri, Sep 20, 2019 at 02:54:38PM +0800, Xiaoming Ni wrote:
>> Use kzalloc() to allocate memory in jffs2_fill_super().
>> Freeing memory when jffs2_parse_options() fails will cause
>> use-after-free and double-free in jffs2_kill_sb()
> 
> ... so we are not freeing it there.  What's the problem?

No code logic issues, no memory leaks

But there is too much code logic between memory allocation and free,
which is difficult to understand.

The modified code is easier to understand.

thanks

Xiaoming Ni