linux-kernel - Re: [PATCH -next] PCI: tegra: Add missing include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c864f34-a2a2-0057-5768-ed992871e927@nvidia.com>
Date:   Fri, 20 Sep 2019 08:47:25 +0530
From:   Vidya Sagar <vidyas@...dia.com>
To:     YueHaibing <yuehaibing@...wei.com>, <lorenzo.pieralisi@....com>,
        <andrew.murray@....com>, <bhelgaas@...gle.com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <treding@...dia.com>
CC:     <linux-pci@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] PCI: tegra: Add missing include file

On 9/20/2019 7:18 AM, YueHaibing wrote:
> Fix build error without CONFIG_PINCTRL
> 
> drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp:
> drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state;
>   did you mean prandom_seed_full_state? [-Werror=implicit-function-declaration]
>    ret = pinctrl_pm_select_default_state(dev);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          prandom_seed_full_state
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index 09ed8e4..b219d3b2 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -28,6 +28,7 @@
>   #include <linux/reset.h>
>   #include <linux/resource.h>
>   #include <linux/types.h>
> +#include <linux/pinctrl/consumer.h>
>   #include "pcie-designware.h"
>   #include <soc/tegra/bpmp.h>
>   #include <soc/tegra/bpmp-abi.h>
> 

Thanks for pushing this change.

Reviewed-by: Vidya Sagar <vidyas@...dia.com>