linux-kernel - Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190920151845.GB10172@e121166-lin.cambridge.arm.com>
Date:   Fri, 20 Sep 2019 16:18:45 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Andrew Murray <andrew.murray@....com>
Cc:     Arnd Bergmann <arnd@...db.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Vidya Sagar <vidyas@...dia.com>,
        Thierry Reding <treding@...dia.com>, linux-pci@...r.kernel.org,
        YueHaibing <yuehaibing@...wei.com>, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h

On Fri, Sep 20, 2019 at 04:07:14PM +0100, Andrew Murray wrote:
> On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote:
> > Without this, we can run into a build failure:
> > 
> > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
> > 
> > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Thanks for this. Another fix for this came in earlier today:
> 
> https://patchwork.ozlabs.org/patch/1165139/

I have applied it since it came in earlier.

Thanks,
Lorenzo

> Reviewed-by: Andrew Murray <andrew.murray@....com>
> 
> Thanks,
> 
> Andrew Murray
> 
> > ---
> >  drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index 09ed8e473cff..f89f5acee72d 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -22,6 +22,7 @@
> >  #include <linux/of_pci.h>
> >  #include <linux/pci.h>
> >  #include <linux/phy/phy.h>
> > +#include <linux/pinctrl/consumer.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/pm_runtime.h>
> >  #include <linux/random.h>
> > -- 
> > 2.20.0
> >