linux-kernel - RE: [PATCH v2] Drivers: hv: vmbus: Fix harmless building warnings without CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM5PR21MB0137310964E95FD225972004D7880@DM5PR21MB0137.namprd21.prod.outlook.com>
Date:   Fri, 20 Sep 2019 17:41:31 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     Dexuan Cui <decui@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>
Subject: RE: [PATCH v2] Drivers: hv: vmbus: Fix harmless building warnings
 without CONFIG_PM_SLEEP

From: Dexuan Cui <decui@...rosoft.com> Sent: Thursday, September 19, 2019 2:46 PM
> 
> If CONFIG_PM_SLEEP is not set, we can comment out these functions to avoid
> the below warnings:
> 
> drivers/hv/vmbus_drv.c:2208:12: warning: ‘vmbus_bus_resume’ defined but not used [-
> Wunused-function]
> drivers/hv/vmbus_drv.c:2128:12: warning: ‘vmbus_bus_suspend’ defined but not used [-
> Wunused-function]
> drivers/hv/vmbus_drv.c:937:12: warning: ‘vmbus_resume’ defined but not used [-
> Wunused-function]
> drivers/hv/vmbus_drv.c:918:12: warning: ‘vmbus_suspend’ defined but not used [-
> Wunused-function]
> 
> Fixes: 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for
> hibernation")
> Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself for
> hibernation")
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> ---
> 
> In v2:
> 	test CONFIG_PM_SLEEP rather than CONFIG_PM. Thanks, Arnd!
> 
>  drivers/hv/vmbus_drv.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by:  Michael Kelley <mikelley@...rosoft.com>