linux-kernel - Re: [PATCH] dimlib: make DIMLIB a hidden symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 20 Sep 2019 19:58:51 +0200
From:   Uwe Kleine-König <uwe@...ine-koenig.org>
To:     Tal Gilboa <talgi@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Arthur Kiyanovski <akiyano@...zon.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] dimlib: make DIMLIB a hidden symbol

Hello,

On 9/20/19 7:02 PM, Tal Gilboa wrote:
> On 9/20/2019 4:31 PM, Uwe Kleine-König wrote:
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index cc04124ed8f7..9fe8a21fd183 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -555,8 +555,7 @@ config SIGNATURE
>>   	  Implementation is done using GnuPG MPI library
>>   
>>   config DIMLIB
>> -	bool "DIM library"
>> -	default y
>> +	bool
>>   	help
>>   	  Dynamic Interrupt Moderation library.
>>   	  Implements an algorithm for dynamically change CQ moderation values
>>
> There's a pending series using DIM which didn't add the select clause 
> [1]. Arthur, FYI. Other than that LGTM.

IMHO this should be fixed, as otherwise the config with the new code
enabled and DIMLIB disabled will fail to build also without my change.

Best regards
Uwe



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)