linux-kernel - Re: [PATCH] mbox: qcom: avoid unused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2j6QG19i3YtRPh7qD4Zr5TiHmK_5=s9mSD2pHVmE99HA@mail.gmail.com>
Date:   Fri, 20 Sep 2019 21:27:50 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mbox: qcom: avoid unused-variable warning

On Fri, Sep 20, 2019 at 6:45 PM Stephen Boyd <sboyd@...nel.org> wrote:
> > @@ -54,11 +60,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> >         void __iomem *base;
> >         unsigned long i;
> >         int ret;
> > -       const struct of_device_id apcs_clk_match_table[] = {
>
> Does marking it static here work too? It would be nice to limit the
> scope of this variable to this function instead of making it a global.
> Also, it might be slightly smaller code size if that works.

No, I just tried and the warning returned.

      Arnd